search

element-hq / matrix-content-scanner-python

A web service for scanning media hosted by a Matrix media repository
Apache License 2.0
13 stars 9 forks source link

Replace twisted with aiohttp #39

Closed babolivier closed 2 years ago

babolivier commented 2 years ago

I'm also using this as an opportunity to switch async test cases to unittest's native async test case (since that's available as of Python 3.8), which fixes #38.

See https://github.com/matrix-org/matrix-content-scanner-python/pull/37#issuecomment-1308933114 for context into what triggered this work.

babolivier commented 2 years ago

I've also renamed the servlets module into http as "servlets" felt a bit antiquated a term to me and aiohttp uses "handlers" which is more in line with more recent web applications. Happy to revert if people feel unhappy about this decision.

babolivier commented 2 years ago

I've also renamed the servlets module into http as "servlets" felt a bit antiquated a term to me and aiohttp uses "handlers" which is more in line with more recent web applications. Happy to revert if people feel unhappy about this decision.

Nevermind, actually it probably makes things more confusing when comparing with other projects of ours, and also causes conflicts and issues, so I've reverted that change.