element-hq / riot-android

A glossy Matrix collaboration client for Android
Apache License 2.0
1.4k stars 394 forks source link

Support filtering joins/leaves #1038

Open izzy opened 7 years ago

izzy commented 7 years ago

With the IRC bridge we get a lot of leave/join meta messages in some channels, especially when mobile clients are constantly joining the IRC channel. It would be nice if there was an option to not display the leave/join messages, e.g. have a filter checkbox in the settings for the channel.

ghost commented 7 years ago

+1 on having a per-room setting to filter out joins/parts completely, not just the folding that Riot-Web does now.

krombel commented 7 years ago

the filtering might be implemented as sync-filter to reduce data-consumption... (maybe in a second step)

t3chguy commented 6 years ago

@krombel no it can't, because then you can't keep your user list up to date

t3chguy commented 6 years ago

This seems now done though, at least there is an option for it in settings

t3chguy commented 6 years ago

This seems implemented except seems to also hide avatar changes and such even with that option unticked

ghost commented 6 years ago

It's only implemented globally. There are no room-specific settings.

t3chguy commented 6 years ago

Are you sure that there just isn't a UI for it? in riot-web that is the case

ghost commented 6 years ago

Riot Android is my daily driver. If there's a per-room setting to filter out joins and leaves, it is very well hidden.

t3chguy commented 6 years ago

I'm saying it might be possible by setting a custom account_data field. e.g via /devtools in riot-web I'm not sure if riot-android supports reading Granular Settings like riot-web does (every setting that makes sense can be set per-room, per-room-per-device etc)

ghost commented 6 years ago
matrix-android-sdk$ git log | grep -i granular
matrix-android-sdk$

riot-android$ git log | grep -i granular
riot-android$ 
t3chguy commented 6 years ago

thats the project name, the code doesn't need to include it. it stores things in im.vector.web.settings in room_account_data and account_data