Crash on clicking link without "http://" prefix

element-hq / riot-android

A glossy Matrix collaboration client for Android

Apache License 2.0

1.4k stars 394 forks source link

Crash on clicking link without "http://" prefix #633

Open elahn opened 7 years ago

elahn commented 7 years ago

Steps to reproduce:

post a link using markdown [link](anywebsite.com)
"click" the link

Zarokka commented 7 years ago

it does not seem to crash on develop branch, but it does not open the link either

this may be better solved in the matrix sdk because if just randomurl.org is posted, VectorMessageListFragment.onURLClick is called with http://randomlink.org, but if [link](randomurl.org) is used, the same method is called with randomurl.org

so from my very limited (noob to the project) perspective, it looks like the matrix sdk handels this already for some links, but not for others