element-hq / riot-android

A glossy Matrix collaboration client for Android
Apache License 2.0
1.4k stars 394 forks source link

ux: lockpad is far too prominent #820

Open cyphar opened 7 years ago

cyphar commented 7 years ago

The lockpad in the Android app is very large, and is a bit too much. Signal has a much more subtle lock icon, where it's underneath a message and much smaller than the message text. Though adopting that style would require having a two-line UX for messages.

ylecollen commented 7 years ago

Do you talk about about the room activity ? the one near the edit text ?

cyphar commented 7 years ago

Yes. Not to mention that once encryption is enabled for a room it can't be disabled, there must be some nicer way of presenting "this is encrypted".

ghost commented 7 years ago

It's not really too big per say, but it looks pretty cramped between my own avatar and the "Type a message" text. One for the UI team I think.

ghost commented 6 years ago

How about putting it in front of the timestamp ?

dkanada commented 6 years ago

@bmarty What about showing the icon only if it is not the default state of the room? So if the room is encrypted only show the icon for unencrypted messages or unverified devices, and if the room is unencrypted only showing the icon for encrypted messages.

bmarty commented 6 years ago

@dkanada I think we are talking about this one, which is a little big when the lock is open:

lock_icon

dkanada commented 6 years ago

Ah, my bad I didn't notice. What if that one was a badge on the user avatar right next to it, similar to the chat icons in the main activity? I think it would get the point across but it might also be inconsistent design. Another option is not using an icon at all and just keeping the hint text.

The design really depends on where the encryption feature is heading. In the room settings there is a note that encryption can be toggled in the future, is that still planned? Also, will users ever be able to send non-encrypted messages to an encrypted room and vice versa, or is matrix not set up that way?

Should I open a new issue for the message encryption status icon? I feel like the two are somewhat related.

dkanada commented 6 years ago

Another option is modifying the lock icon to be uniform for both states, like the android icons below. That is outside my scope though since I am guessing that would be a cross platform change.

lock lock-open

bmarty commented 6 years ago

A designer is working on the future version of Riot, I'm pretty sure the Room screen will be refreshed.

CC @nadonomy

dkanada commented 6 years ago

I wasn't aware that was happening. Will the matrix blog cover planned design changes as well or is there another place I can follow those discussions?

danielfrankcom commented 5 years ago

Are the mentioned future changes still going on? Is there somewhere that the progress or the plan itself can be viewed? Thanks.