Ability for clients to clear their notifs serverside if sending RRs is disabled

element-hq / riot-meta

A place to experiment with tracking features at a higher level than Riot web/iOS/Android.

25 stars 6 forks source link

Ability for clients to clear their notifs serverside if sending RRs is disabled #66

Open ara4n opened 7 years ago

ara4n commented 7 years ago

https://github.com/vector-im/riot-web/issues/2527 is the main bug for letting clients not send RRs for privacy if desired.

However, this causes problems because RRs are currently the only way to mark notifs as read - otherwise you end up with badge counts accumulating on all clients.

This is a meta bug to track adding an API to mark notifs as read, and implement it on the 3 clients so they clear notifs on launch if RRs are disabled.

https://github.com/vector-im/riot-android/issues/1151 is the bug for Android.

ghost commented 7 years ago

Why clear on launch? Doesn't that defeat the purpose of notifs? If they were cleared per-room, on opening the room, there would be no loss in functionality.

turt2live commented 7 years ago

When opening the room makes sense to me. Even more desirable would be to use read markers for badge counts instead of receipts, so that the badges are synchronized across clients.

ara4n commented 7 years ago

badge counts should already be synchronized; sending an RR (not RM) on one device will trigger badge counts to be recalculated and pushed to everyone.

Agreed that the unread count should be reset on opening the room. Or even ideally, we should reset it whenever previously we would have sent an RR. In other words, we need to differentiate between local-read state and remotely-viewable-read state.

Perhaps a nicer solution would be to put some metadata on m.read receipts to indicate whether they should be visible to other users or not...

erdnaxeli commented 7 years ago

IMHO:

the RM should be use for all private information: what I've read, how many notification I'm missing, and so on.
the RR should only be used to notify all people in the room that you have read till some event (public information), but you should be able to have working notifications and room marked as read without it.

The downside of this if that the RM can far away in the history of a room, while you still want it to be marked as read (I personally don't like to keep a RM far away, but some people seem to do it) . So maybe we should support a mix of RM and RR and use the last recent one to compute unread rooms and notifications.

Krinkle commented 4 years ago

Has a decision been made?