`event_id` in `event_search` should have a `NOT NULL` constraint

element-hq / synapse

Synapse: Matrix homeserver written in Python/Twisted.

https://element-hq.github.io/synapse

GNU Affero General Public License v3.0

1.5k stars 184 forks source link

`event_id` in `event_search` should have a `NOT NULL` constraint #16458

Open matrixbot opened 10 months ago

matrixbot commented 10 months ago

This issue has been migrated from #16458.

edit: oddly, matrix.org does have the NOT NULL constraint on this table. But librepush.net and reading the schema deltas shows that it doesn't in mainline Synapse...

richvdh commented 8 months ago

Part of https://github.com/element-hq/synapse/issues/11893.

(it should also have a foreign key reference on events, imho; cf https://github.com/element-hq/synapse/issues/12817)