element-hq / synapse

Synapse: Matrix homeserver written in Python/Twisted.
https://element-hq.github.io/synapse
GNU Affero General Public License v3.0
1.61k stars 203 forks source link

MSC4171 Omit service members from room summary #17866

Closed Half-Shot closed 3 weeks ago

Half-Shot commented 1 month ago

For #17859

This applies the rules for MSC4171 to the m.heroes response in sync. For clarity, this PR is needed to fix behaviors in some modern clients such as EX which use heroes to determine room names rather than local calculation.

MSC discussion for excluding service members from m.heroes: https://github.com/matrix-org/matrix-spec-proposals/pull/4171#discussion_r1688649042

Pull Request Checklist

Half-Shot commented 3 weeks ago

I think on balance and after talking to @erikjohnston, we have the ability to do this filtering in the client and it sounds trivial to do so from both v2 and sliding sync. Let's do that, and if that ends up being annoying then we can circle back to a backend implementation.