Yushu2606 commented 3 weeks ago

Pull Request Checklist

[x] Pull request is based on the develop branch
[x] Pull request includes a changelog file. The entry should:
- Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
- Use markdown where necessary, mostly for code blocks.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
- Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
[x] Code style is correct (run the linters)

CLAassistant commented 3 weeks ago

All committers have signed the CLA.

Yushu2606 commented 3 weeks ago

17878

S7evinK commented 3 weeks ago

Can you incorporate the changes from #17878 in this PR? CI is complaining that _nameEncoder can not be found (well, Twisted isn't updated yet, so that makes sense)

Yushu2606 commented 3 weeks ago

Can you incorporate the changes from #17878 in this PR? CI is complaining that _nameEncoder can not be found (well, Twisted isn't updated yet, so that makes sense)

ok, sure

devonh commented 2 weeks ago

These changes have been superceded by this PR https://github.com/element-hq/synapse/pull/17894. It removes the usage of internal header encoding API completely.

element-hq / synapse

Adapt to Twisted 24.10.0rc1 #17886

Pull Request Checklist

17878