elementary-data / elementary

The dbt-native data observability solution for data & analytics engineers. Monitor your data pipelines in minutes. Available as self-hosted or cloud service with premium features.
https://www.elementary-data.com/
Apache License 2.0
1.92k stars 164 forks source link

Support DuckDB warehouse #1124

Open ntnhaatj opened 1 year ago

ntnhaatj commented 1 year ago

First of all, thank you for your awesome product.

Is your feature request related to a problem? Please describe. No, this is not motivated by a problem. It's about supporting an additional warehouse that I believe would be highly suitable for data-quality observability.

Why DuckDB?

Would you be willing to contribute this feature? Yes, I am willing to. I've already started development in my forked repository, and it's functional to a certain expectation. However, a few tests are failing, and I would appreciate your guidance to finalize it.

Current limitation While working on my forked repo, I encountered some limitations:

wfclark5 commented 1 year ago

@ntnhaatj How's your progress on this? Were you able to figure out the last few tests?

ntnhaatj commented 1 year ago

@ntnhaatj How's your progress on this? Were you able to figure out the last few tests?

duckdb has just released v0.9.0 (which officially has fixed the shadowing name issue in CTE).

I tested it in my forked branch, it passed almost of defined tests suite, there are a few tests still failed (3 if I remember correctly) which relate to schema change, just don't have time to fix and finish them.

mamonu commented 1 year ago

that is great news. i encountered today an error message when i tried to test how duckdb-dbt works with elementary and my heart sank when i saw: Adapter "duckdb" is not supported on Elementary.

thanks for the work for this

ntnhaatj commented 1 year ago

Hi @mamonu, my work is currently designed for my specific use case, primarily for data quality reporting. It doesn't guarantee the quality and coverage of all elementary features. It might be better to wait until they have official support for DuckDB.

haritamar commented 5 months ago

Hi @ntnhaatj ! Not sure if you made additional work on this since, but if you'd like to contribute DuckDB support we'd be happy to review. I think it's also fine if it will cover a subset of features. Please let me know if you're still interested in contributing this to the main Elementary repo.

Cheers, Itamar