elementary-data / elementary

The dbt-native data observability solution for data & analytics engineers. Monitor your data pipelines in minutes. Available as self-hosted or cloud service with premium features.
https://www.elementary-data.com/
Apache License 2.0
1.94k stars 165 forks source link

DBT Columns for source contains only column that have a description #1668

Closed olivierdet closed 3 months ago

olivierdet commented 3 months ago

Describe the bug DBT columns for source only contains column that have a documentation

To Reproduce 1 - Define tables inside sources 2 - Create 2 columns, one with description the other without Only the column with description will appear in dbt_columns

We have something like

version: 2

sources:
    tables:
      - name: customer
        columns:
          - name: email
            description: Professional email
          - name: first_name
            meta:
              database_tags:
                data_classification: "level_2"

Email appear in dbt_columns, first_name not

Expected behavior

I would expect to have the 2 columns.

Environment (please complete the following information):

Would you be willing to contribute a fix for this issue? Yes, I can help if needed, just don't know where it is located

IDoneShaveIt commented 3 months ago

Hey @olivierdet, thanks for raising that up! This is actually an intended behaviour that we have. By default we only upload columns that have description, but we have a way to control it 🙂

In order to upload all columns, you should set the var upload_only_columns_with_descriptions: false

IDoneShaveIt commented 3 months ago

I am closing this issue 🙂 Please let us know if you still have any question / something is still not working for you 🙏🏻

olivierdet commented 3 months ago

Thanks, it works. I don't find it anywhere in the documentation. Is it intended ?