search

elementary-data / elementary

The dbt-native data observability solution for data & analytics engineers. Monitor your data pipelines in minutes. Available as self-hosted or cloud service with premium features.
https://www.elementary-data.com/
Apache License 2.0
1.94k stars 165 forks source link

Add support for arm architecture in the published docker image #1699

Closed FrankTub closed 2 months ago

FrankTub commented 2 months ago

Is your feature request related to a problem? Please describe.

Recently we modified our (Gitlab) CI runners to a different architecture (from intel to arm). We use the published docker image of elementary and run it on one of our Gitlab CI runners. Since we changed to this new architecture all edr commands fail on this runner. We think it is related to the architecture of the docker image.

Describe the solution you'd like

Possibly publish multi-architecture docker images, see this for more info. And if not possible add another image specific for arm architecture.

Describe alternatives you've considered

Built my own image from scratch.

Additional context

The error we receive:

exec /usr/local/bin/edr: exec format error

Would you be willing to contribute this feature?

Yes if you would tell me what you guys do to publish your images.

FrankTub commented 2 months ago

Think it would be a very small change in .github/workflows/release.yml. My collegeau opened a PR for it: https://github.com/elementary-data/elementary/pull/1701

ofek1weiss commented 2 months ago

Hey @FrankTub, ill take a look at the pr, lets continue the conversation there 👍