elementary-data / elementary

The dbt-native data observability solution for data & analytics engineers. Monitor your data pipelines in minutes. Available as self-hosted or cloud service with premium features.
https://www.elementary-data.com/
Apache License 2.0
1.94k stars 165 forks source link

GH-1699 Setup multi-platform Docker images to support both x86 and arm architectures #1701

Closed JanDintel closed 2 months ago

JanDintel commented 2 months ago

Introduction

Support multiple platforms (architectures) for the Docker container in the Github Action release.

In this way open-source users can run the Docker image on both x86 and arm architectures. Rational behind this is because more cloud providers are supporting arm architectures with provide a better price-performance.

Closed GH-1699

Supporting documentation

ofek1weiss commented 2 months ago

Hey @JanDintel , looks great 🚀 make sure to update your branch with master and ill make sure it is merged 😁

ofek1weiss commented 2 months ago

@JanDintel Just one thing, looks like in the empty lines you added, there are whitespaces which our code quality check does not seem to like, make sure to remove those

JanDintel commented 2 months ago

@ofek1weiss thank you for the review! I've updated the file to remove the unnecessary white spacing and the previously failing pre-commit hook for prettier passed locally.

ofek1weiss commented 2 months ago

@JanDintel 🎉