elementary-data / elementary

The dbt-native data observability solution for data & analytics engineers. Monitor your data pipelines in minutes. Available as self-hosted or cloud service with premium features.
https://www.elementary-data.com/
Apache License 2.0
1.94k stars 165 forks source link

unnecessary warning for exposure_schema_validity test #1708

Open data-blade opened 1 month ago

data-blade commented 1 month ago

Describe the bug given exposure_a and exposure_b,

each with just model_x in their depends_on,

each only specifying column_name.

running exposure_schema_validity will yield this warning for each exposure and column

Warning - missing node property for the exposure: <exposure> which not the only exposure depending on <model>, We're not able to verify the column level dependencies of this exposure

To Reproduce create a simple setup with exposure_a, exposure_b and model_x as described above

Expected behavior no warning, since model_x is the only model in the depends_on of each exposure, therefore no node property should be needed

Screenshots n/a

Environment

Additional context the test passes despite the warning

Would you be willing to contribute a fix for this issue? if time allows

haritamar commented 1 month ago

Hi @data-blade ! Thanks for opening this issue, it indeed looks to me like a bug - it seems that what we're currently checking is whether or not there is more than one exposure depending on the same node, but I'm not sure why that is the check.

It may take us a bit of time to get to so if you're willing to contribute a fix will be happy to point to give pointers on where to look.