elementary / appcenter-reviews

Public app reviews for the elementary AppCenter Flatpak repository
22 stars 53 forks source link

Only 64px and 128px icons served from remote #454

Open danirabbit opened 1 year ago

danirabbit commented 1 year ago

What Happened?

AppCenter makes frequent use of 48px icons in lists, however only 64px and 128px icons are served from the remote even if the app has more icon sizes available.

Steps to Reproduce

See https://flatpak.elementary.io/repo/appstream/x86_64/icons/

Expected Behavior

We should provide 48px icons from the remote as well so that we don't get blurry icons in lists or have to bump up to significantly larger 64px icons

OS Version

7.x (Horus)

Software Version

Latest release (I have run all updates)

Log Output

No response

Hardware Info

No response

davidmhewitt commented 1 year ago

The icon sizes to be served are hardcoded in appstream-compose: https://github.com/hughsie/appstream-glib/blob/cbe4aae01a99154464cb865235689bf49d0a48a2/client/as-compose.c#L39-L167