search

elementary / appcenter-web

Web frontend for viewing AppCenter apps
https://appcenter.elementary.io
The Unlicense
43 stars 11 forks source link

actions: Push without using external action #93

Closed davidmhewitt closed 1 year ago

davidmhewitt commented 1 year ago

This should work and removes a deprecated Node 12 action

davidmhewitt commented 1 year ago

Ah, well spotted! This would be able to push to the repo, but the GitHub action to deploy the site afterwards wouldn't run, because actions don't run on commits triggered by the default token (to prevent infinite loops).

I've updated this to use the token with the checkout action, which it will use for the push command too.

RMcNeely commented 1 year ago

Ah, well spotted! This would be able to push to the repo, but the GitHub action to deploy the site afterwards wouldn't run, because actions don't run on commits triggered by the default token (to prevent infinite loops).

I've updated this to use the token with the checkout action, which it will use for the push command too.

Does this mean that we would need to manually deploy the updates after they are committed if they do not run on commits triggered by the default token? Or is that why we are now providing the token instead of using the default token used by checkout v3

davidmhewitt commented 1 year ago

Or is that why we are now providing the token instead of using the default token used by checkout v3

Yes, this should work as before now.

You can see here where we push commits with the elementaryBot token that GitHub actions still run as a result of the pushes: https://github.com/elementary/browser/pull/101