search

elementary / appcenter

Pay-what-you-can app store for elementary OS
https://elementary.io
GNU General Public License v3.0
543 stars 101 forks source link

AppCenter screenshot view page dots should use elementary style #1453

Open hanaral opened 3 years ago

hanaral commented 3 years ago

Problem

Currently they use the default libhandy page dots

Expected Behavior

They should be in the elementary style like the application menu or the online AppCenter

Example

Screenshot from 2020-11-27 15-44-40

cassidyjames commented 3 years ago

They do look slightly different in AppCenter than other apps, even ones also using Handy like Onboarding and Applications Menu. Are we styling those other apps in-app, or is there some other reason this isn't getting the styling @elementary/ux

Screenshot for reference

Screenshot from 2020-12-09 11-14-18

danirabbit commented 3 years ago

I believe this is using the dots from Handy and we're using custom dots in other places.

I actually don't mind the style of these dots at all. I'd be fine dropping our custom dots if there's no practical difference

hanaral commented 3 years ago

I actually don't mind the style of these dots at all. I'd be fine dropping our custom dots if there's no practical difference

I hope I'm not being crass by thinking that there is already a well established elementary style for page dots, and that it should be the same as all the other apps 😅️

In a way I think that it should either be the old style, or something completely new.