search

elementary / applications-menu

Applications Menu for elementary OS and the Pantheon desktop environment
https://elementary.io
GNU General Public License v3.0
103 stars 35 forks source link

Show option to copy calculator result #446

Closed fs3o5 closed 3 years ago

fs3o5 commented 3 years ago

412

jeremypw commented 3 years ago

I would suggest using Granite.TOOLTIP_SECONDARY_TEXT_MARKUP and the text "Click to copy result to clipboard" so that the tooltip conforms to the appearance of other elementary tooltips and also tells the user what to do.

fs3o5 commented 3 years ago

Using Granite.TOOLTIP_SECONDARY_TEXT_MARKUP does not look really good: Screenshot from 2021-01-28 01-03-06 I couldn't find where the other text highlights are set in the search. It would probably be the best to use the same style.

pongloongyeat commented 3 years ago

Perhaps this is what @jeremypw meant

Screenshot from 2021-03-01 19-12-02

jeremypw commented 3 years ago

After my commit there is now a tooltip in standard form (like other wingpanel tooltips) showing how to copy the result:

Screenshot from 2021-04-07 17 50 11

pongloongyeat commented 3 years ago

@jeremypw This appears to copy "2+2=4" rather than the result as is described in the tooltip.

jeremypw commented 3 years ago

@pongloongyeat OOPs! I should have checked that - sorry. Will fix. Thanks for checking

pongloongyeat commented 3 years ago

Please ignore my last 2 reviews. I don't believe it's that important.