davidmhewitt
commented
3 years ago @davidak and/or @worldofpeace could you see if this branch improves the situation of new apps appearing when you install them on NixOS? As described in #182
Closed davidmhewitt closed 3 years ago
davidmhewitt
commented
3 years ago @davidak and/or @worldofpeace could you see if this branch improves the situation of new apps appearing when you install them on NixOS? As described in #182
davidak
commented
3 years ago @davidmhewitt thanks a lot for thinking of us! :sparkles:
worldofpeace is not around anymore. pantheon on nixos in now maintained by @bobby285271 and me.
we can apply this pr as patch and try it out. (@bobby285271 can you apply the patch in the PR?)
davidak
commented
3 years ago It does not fix the issue. In addition, when a program is uninstalled and still show up in the menu and i search, wingpanel crash!
See this screen recording: https://youtu.be/f61_ugF8m3s?t=192
Journal:
When vlc is installed on NixOS, the binary is symlinked to /run/current-system/sw/bin/vlc which is in the PATH. The desktop file is in /run/current-system/sw/share/applications/vlc.desktop. Maybe it has to be aware of that or we would need a patch?
davidmhewitt
commented
3 years ago @davidak Thanks for testing!
That "Execute 'vlc'" entry that appears when you search is something a bit different. That's because wingpanel has detected that there's an executable in the PATH called vlc, but it hasn't picked up on the new .desktop file to properly show it as an application in the menu. If this and #451 were werking properly on NixOS, you'd expect to see a VLC entry with an icon in both the browse and search views.
However, it seems odd that the crash you show would be related to this branch as this doesn't touch any of the search code. Are you able to confirm whether that same crash happens without this patch?
As for fixing the original issue here, what is the XDG_DATA_DIRS environment variable set to?
davidak
commented
3 years ago Are you able to confirm whether that same crash happens without this patch?
yes, it also happen without this patch
As for fixing the original issue here, what is the XDG_DATA_DIRS environment variable set to?
[davidak@gaming:~]$ echo $XDG_DATA_DIRS
/nix/store/g525y961ir5lxmgnraxgwi8myq3vfdqk-elementary-terminal-6.0.0/share:/nix/store/qvmdkg2f09pvlsdr4bqasyiy5g0mbvrd-gtk+3-3.24.30/share/gsettings-schemas/gtk+3-3.24.30:/nix/store/3iikkf41lhl0qmad4hgzsacigh7dy318-gsettings-desktop-schemas-40.0/share/gsettings-schemas/gsettings-desktop-schemas-40.0:/nix/store/g525y961ir5lxmgnraxgwi8myq3vfdqk-elementary-terminal-6.0.0/share/gsettings-schemas/elementary-terminal-6.0.0:/nix/store/qvmdkg2f09pvlsdr4bqasyiy5g0mbvrd-gtk+3-3.24.30/share:/nix/store/rpn40nh1va7h5qi5rnzkfm35qx4xfacp-elementary-icon-theme-6.0.0/share:/nix/store/wx4hg39sdz4fhcv0ibqrxcfnimcbjc7v-hicolor-icon-theme-0.17/share:/nix/store/02b1r3a635n2lfnwn7zr3i48aidvp501-cups-2.3.3/share:/nix/store/iah17gdhv1kc4brzq8lph1mi130x63wz-granite-6.1.0/share:/nix/store/c7x1n344zpxwgpd75kbqhlpmb2y3383c-elementary-dock-unstable-2021-07-16/share:/nix/store/qvmdkg2f09pvlsdr4bqasyiy5g0mbvrd-gtk+3-3.24.30/share/gsettings-schemas/gtk+3-3.24.30:/nix/store/3iikkf41lhl0qmad4hgzsacigh7dy318-gsettings-desktop-schemas-40.0/share/gsettings-schemas/gsettings-desktop-schemas-40.0:/nix/store/c7x1n344zpxwgpd75kbqhlpmb2y3383c-elementary-dock-unstable-2021-07-16/share/gsettings-schemas/elementary-dock-unstable-2021-07-16:/nix/store/yz42vy9zsr3q2m9pd4kmjdwj1b3jz9gl-elementary-session-settings-6.0.0/share:/nix/store/iflb5fmlddbk44xzbr7fk4pzgdfr2dyh-desktops/share:/home/davidak/.nix-profile/share:/etc/profiles/per-user/davidak/share:/nix/var/nix/profiles/default/share:/run/current-system/sw/share:/nix/store/kazsj4q435j887is5ds0h6dh5x233146-pantheon-agent-geoclue2-1.0.5/share/gsettings-schemas/pantheon-agent-geoclue2-1.0.5:/nix/store/8clrvfrmbb6pkr9lnpq20xh23afq4bwm-gnome-session-40.1.1/share:/nix/store/3iikkf41lhl0qmad4hgzsacigh7dy318-gsettings-desktop-schemas-40.0/share/gsettings-schemas/gsettings-desktop-schemas-40.0:/nix/store/qvmdkg2f09pvlsdr4bqasyiy5g0mbvrd-gtk+3-3.24.30/share/gsettings-schemas/gtk+3-3.24.30:/nix/store/x86flsipciznq893xybyx30dhidi8avc-gnome-settings-daemon-40.0.1/share/gsettings-schemas/gnome-settings-daemon-40.0.1:/nix/store/8clrvfrmbb6pkr9lnpq20xh23afq4bwm-gnome-session-40.1.1/share/gsettings-schemas/gnome-session-40.1.1:/nix/store/h76lkz35bdcb6gs9xxs7l6qf1wpvfhvc-gnome-shell-40.4/share
Fixes #440 (well, it should but I haven't 100% confirmed it yet because I need to install this on a clean install) Fixes https://github.com/elementary/appcenter/issues/1120
This is the equivalent of #451 , but for the grid and list views instead of the search results views.
Desktop files (and any changes to them) are now read via standard GLib libraries instead of via libgnome-menu which didn't seem to be noticing when you installed a flatpak for the first time.
Pros:
Cons: