elementary / applications-menu

Applications Menu for elementary OS and the Pantheon desktop environment
https://elementary.io
GNU General Public License v3.0
103 stars 35 forks source link

Incorrectly named instant answer #498

Closed kdwk closed 1 year ago

kdwk commented 3 years ago

What Happened

Screenshot from 2021-08-23 10-06-07

Calculation result is incorrectly shown as 'Text', which is confusing to users. What does it mean by 'text'?

Expected Behavior

Give it a more descriptive label, like 'Calculate' or 'Compute'

Steps to Reproduce

  1. Type in a simple mathematical equation
  2. Observe the label for the instant answer

Logs

Platform Information

Screenshot from 2021-08-23 10-10-38

jeremypw commented 3 years ago

The header "Text" seems to come from the match type used by the calculator plugin (MatchType.TEXT). All entries not already parsed as e.g. an Application, Action or Link are passed to the calculator which then further parses them to see if they are calculations. In principle there could be more than one plugin which receives unparsed entries and each would return results under the "Text" header each with its own icon. In practice, only calculator plugin accepts unparsed text afaict so it is a bit puzzling.