elementary / applications-menu

Applications Menu for elementary OS and the Pantheon desktop environment
https://elementary.io
GNU General Public License v3.0
104 stars 35 forks source link

Fix navigation by keyboard in GridView #585

Closed jeremypw closed 3 weeks ago

jeremypw commented 9 months ago

Fixes #584 Fixes #388

Supercedes #445

jeremypw commented 1 month ago

Investigating incorporating @danirabbit PRs using child-focus

jeremypw commented 1 month ago

Looks like child-focus works well within a single grid but there is no obvious way of having the appropriate child focused when moving to another grid without keeping track of the focussed row and focussed column as we do now. In which case, the advantages of changing seem minimal.

@danirabbit Is it OK to go ahead with the current fix and may be use child-focus later if a cleaner implementation is found?

danirabbit commented 1 month ago

That's the roadblock I ran into as well. I haven't looked at this branch yet but I agree that there's not much of an advantage to using child focus if you have to keep track of grid position anyways when switching pages