search

elementary / browser

Epiphany Flatpak Ref
GNU General Public License v3.0
4 stars 4 forks source link

Epiphany should block trackers and related advertisements #68

Closed moonmehta closed 2 years ago

moonmehta commented 5 years ago

Forgive me for filing this bug here as I couldn't find any repo for the slightly-modified Epiphany being shipped by elementary.

For a company with a strong stance on privacy by design, it is somewhat strange to see the default elementary browser shipping with the setting of "Block advertisements" and "Block trackers" turned off. Even upstream has the settings on, but elementary has explicitly turned it off it seems (?). screenshot from 2019-02-27 07-10-48

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/77993210-epiphany-should-block-trackers-and-related-advertisements?utm_campaign=plugin&utm_content=tracker%2F74974394&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F74974394&utm_medium=issues&utm_source=github).
peteruithoven commented 5 years ago

Thanks for the report. This isn't the right repo though, please see: https://gitlab.gnome.org/GNOME/epiphany/blob/master/CONTRIBUTING.md

In a future release of the About plug there will be an option for Epiphany (see PR) linking to:

Since we can't move issues to gitlab I'm closing this issue.

cassidyjames commented 5 years ago

@peteruithoven since this issue is about default settings of Epiphany in elementary OS, it does belong here. We change certain settings downstream in our OS.

moonmehta commented 5 years ago

Not to press, but it'd be great to have this by default in the Juno 5.1 release. I've never coded, but would be happy to file a PR given apt guidance.

cassidyjames commented 5 years ago

Epiphany patches are in this branch: https://github.com/elementary/os-patches/tree/epiphany-browser-bionic-patched

moonmehta commented 5 years ago

As I said, I've never coded. Could you please help me with finding the relevant setting that controls this as well as elementary/os-patches#58 and elementary/os-patches#60? I will learn the process and file a PR! :D

cassidyjames commented 5 years ago

Ah, my bad, this actually is a default-settings issue (I misunderstood it). Transferring back there. Basically, we ship a set of default settings (which includes overrides of the upstream defaults). We don't currently enable the ad-blocking and tracker-blocking options, I believe due to their impact on performance plus the possibility of breaking websites. I'm not sure that we would want to enable them by default in their current state. However, WebKit developers are working on more performant and robust tracker blocking code within WebKit itself, and it would be worth looking into enabling that once it ships.

cassidyjames commented 5 years ago

@uncertainquark Epiphany overrides start here: https://github.com/elementary/default-settings/blob/848a8bfc1d3bae9945f51498d8b9ae2cc0d39911/overrides/default-settings.gschema.override#L98

Some may be self-explanatory, but if you open up dconf-editor on your elementary desktop, browse to /org/gnome/epiphany/, then toggle the settings, you should see what changes and to what values. You'd simply need to edit that file and submit a PR with the edit to this repo and then we can test and decide if it's something we should actually turn on.

danirabbit commented 2 years ago

It looks like ad blocking is enabled by default these days :)