search

elementary / browser

Epiphany Flatpak Ref
GNU General Public License v3.0
4 stars 4 forks source link

Epiphany doesn't block popup windows like every other browser #69

Closed moonmehta closed 2 years ago

moonmehta commented 5 years ago

Forgive me for filing this bug here as I couldn't find any repo for the slightly-modified Epiphany being shipped by elementary.

Popup windows are almost always intrusive and all industry-standard browsers (Chrome, Firefox, Opera, Brave, etc. have the setting to block popup windows turned on. Elementary's default browser should turn it on too. screenshot from 2019-02-27 07-10-48

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/77993427-epiphany-doesn-t-block-popup-windows-like-every-other-browser?utm_campaign=plugin&utm_content=tracker%2F74974394&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F74974394&utm_medium=issues&utm_source=github).
peteruithoven commented 5 years ago

Thanks for the report. This isn't the right repo though, please see: https://gitlab.gnome.org/GNOME/epiphany/blob/master/CONTRIBUTING.md

In a future release of the About plug there will be an option for Epiphany (see PR) linking to:

Since we can't move issues to gitlab I'm closing this issue.

cassidyjames commented 5 years ago

@peteruithoven since this issue is about default settings of Epiphany in elementary OS, it does belong here. We change certain settings downstream in our OS.

moonmehta commented 5 years ago

Not to press, but it'd be great to have this by default in the Juno 5.1 release. I've never coded, but would be happy to file a PR given apt guidance.

cassidyjames commented 5 years ago

Epiphany patches are in this branch: https://github.com/elementary/os-patches/tree/epiphany-browser-bionic-patched

cassidyjames commented 5 years ago

As on the other issues, I was misunderstanding this, and didn't realize you were just talking about the existing setting. default-settings is actually the right place. I'll point you in the right direction in a sec. :smile:

I think the big thing here is that we'd need to dogfood it quite a bit and make sure it's not unintentionally breaking sites.

cassidyjames commented 5 years ago

@uncertainquark Epiphany overrides start here: https://github.com/elementary/default-settings/blob/848a8bfc1d3bae9945f51498d8b9ae2cc0d39911/overrides/default-settings.gschema.override#L98

Some may be self-explanatory, but if you open up dconf-editor on your elementary desktop, browse to /org/gnome/epiphany/, then toggle the settings, you should see what changes and to what values. You'd simply need to edit that file and submit a PR with the edit to this repo and then we can test and decide if it's something we should actually turn on.

danirabbit commented 2 years ago

Looks like these days popup blocking is enabled by default :)