search

elementary / browser

Epiphany Flatpak Ref
GNU General Public License v3.0
4 stars 4 forks source link

Bump to 44 #83

Closed danirabbit closed 1 year ago

danirabbit commented 1 year ago

Related discussion at https://github.com/elementary/browser/discussions/82

Fixes #53 Fixes #78 Fixes #90 Fixes #92

Sync with https://github.com/flathub/org.gnome.Epiphany/commit/5c28b6ae551b95ce6afaadbd04a1c437e6e41748

stan-janssen commented 1 year ago

I’ve been trying this version of Web for the past few days, and I think there might be a few issues. I tried to make a screen recording of it, but it did not really come across. I’m comparing three versions: the AppCenter version (the current, ‘old’ version), the Pull Request version (this version) and the Flathub version, which is the current Gnome version.

  1. The browser dialogs seem to be not styled properly. This happens on both the Pull Request version and the Flathub version. Can others reproduce this?

browser-dialog

  1. Videos in a <video> tag don't seem to play. They do play on the current AppCenter version and on the current Flathub version. Can anyone else reproduce this? For instance, the videos on this Github.com pull request: https://github.com/elementary/wingpanel/pull/481

  2. On the Pull Request version and on the Flathub version, scrolling has... changed? Perhaps this is intentional and it’s not neccessarily a blocking issue. I use a Starbook MK V and on the current AppCenter version, the scrolling intertia is the same between Web and the other elementaryOS apps like Mail and Code. On the new version, the inertia is much "stiffer": it breaks much harder after you flick and stops scrolling sooner, if that makes sense. I'm not sure if anyone else has one of these laptops or can reproduce this on a different system.

I'd be more than happy to help try to figure these things out properly by the way. Let me know if I can do anything to help!

stan-janssen commented 1 year ago

If it helps, this is how I’m starting these different versions (after installing them):

danirabbit commented 1 year ago

@stan-janssen

  1. Can you open an issue report about this on elementary/stylesheet? I'm guessing this is Adw.Dialog. It could be styled better, but I'm not sure I would consider this release blocking
  2. I can confirm video playback isn't working here. My guess is this is due to missing GL platform or something. I'll investigate :)
  3. I think scrolling is changing in WebKitGTK. Since this also occurs in the Flathub version it would be good to report that upstream in the Ephy gitlab
mcatanzaro commented 1 year ago

I think scrolling is changing in WebKitGTK. Since this also occurs in the Flathub version it would be good to report that upstream in the Ephy gitlab

For problems with scrolling, use WebKit Bugzilla, WebKitGTK component

stan-janssen commented 1 year ago
  1. Can you open an issue report about this on elementary/stylesheet? I'm guessing this is Adw.Dialog. It could be styled better, but I'm not sure I would consider this release blocking

I agree that it’s not a blocking issue. The dialog still works fine :-)

Here’s the issue on this: https://github.com/elementary/stylesheet/issues/1251

stan-janssen commented 1 year ago

Another non-blocking thing that would be nice to get back sometime is the two-finger gestures for back/forward navigation that are no longer there in the new version.

mcatanzaro commented 1 year ago

Another non-blocking thing that would be nice to get back sometime is the two-finger gestures for back/forward navigation that are no longer there in the new version.

That's unexpected. 🙀️

danirabbit commented 1 year ago

In the interest of trying to get this fix out, I tried building Web 43 against the newer runtime and it also has the same video playback issue https://github.com/elementary/browser/pull/95

Marukesu commented 1 year ago

In the interest of trying to get this fix out, I tried building Web 43 against the newer runtime and it also has the same video playback issue #95

about the video issue, looks like the runtime isn't mounting the openh264 extension at all on 7.2.

7.1 (look at the runtime-extensions key):

$ flatpak run --command=cat org.gnome.Epiphany /.flatpak-info
[Application]
name=org.gnome.Epiphany
runtime=runtime/io.elementary.Platform/x86_64/7.1

[Instance]
instance-id=1271510550
instance-path=/home/marukesu/.var/app/org.gnome.Epiphany
app-path=/var/lib/flatpak/app/org.gnome.Epiphany/x86_64/stable/2143b6f2504e107de8297a5c1d82143426e1bb079051f4db79f76c98e476d134/files
app-commit=2143b6f2504e107de8297a5c1d82143426e1bb079051f4db79f76c98e476d134
app-extensions=org.gnome.Epiphany.Locale=9f0f43e07a3ff60ff53ba9d1718fa9a9073e01ac03956c99a69787cd33de9d0f
runtime-path=/var/lib/flatpak/runtime/io.elementary.Platform/x86_64/7.1/4f56a6ec546ed074c874fc464548fc6685e28be6f42588660d5f2809f06d0511/files
runtime-commit=4f56a6ec546ed074c874fc464548fc6685e28be6f42588660d5f2809f06d0511
runtime-extensions=org.freedesktop.Platform.GL.default=16b56ade0efe531eb94a9b0055736f304dd8060d6b3720cf044fed6033396500;org.freedesktop.Platform.VAAPI.Intel=5726d0f2e50f2a759bf1d1aedde620c13f3601e6c2d09e1f81f86f1b449d2f4c;org.freedesktop.Platform.openh264=d4d0d2d188da14f4250dbd4aea74211344ea2647e64bc139952b79af6c480087;org.freedesktop.Platform.openh264=bf24f23f3ba385f6e8c9215ed94d979db99814b0b614504a23a6d0751dc5f063;io.elementary.Platform.Locale=c61739f7e4e6240f32733ee66ab9c65062be2a906502caf315fca7a39bee9684
branch=stable
arch=x86_64
flatpak-version=1.14.2
session-bus-proxy=true
system-bus-proxy=true

[Context]
shared=network;ipc;
sockets=x11;wayland;pulseaudio;fallback-x11;
devices=dri;
filesystems=xdg-download;

[Session Bus Policy]
org.gnome.Epiphany.WebAppProvider=own

[System Bus Policy]
org.freedesktop.GeoClue2=talk

[Environment]
GI_TYPELIB_PATH=/app/lib/girepository-1.0
ALSA_CONFIG_PATH=/usr/share/alsa/alsa-flatpak.conf
XDG_DATA_DIRS=/app/share:/usr/share:/usr/share/runtime/share:/run/host/share
ALSA_CONFIG_DIR=/usr/share/alsa

7.2:

flatpak run --command=cat --runtime-version=7.2 org.gnome.Epiphany /.flatpak-info
[Application]
name=org.gnome.Epiphany
runtime=runtime/io.elementary.Platform/x86_64/7.2

[Instance]
instance-id=2840342194
instance-path=/home/marukesu/.var/app/org.gnome.Epiphany
app-path=/var/lib/flatpak/app/org.gnome.Epiphany/x86_64/stable/2143b6f2504e107de8297a5c1d82143426e1bb079051f4db79f76c98e476d134/files
app-commit=2143b6f2504e107de8297a5c1d82143426e1bb079051f4db79f76c98e476d134
app-extensions=org.gnome.Epiphany.Locale=9f0f43e07a3ff60ff53ba9d1718fa9a9073e01ac03956c99a69787cd33de9d0f
runtime-path=/var/lib/flatpak/runtime/io.elementary.Platform/x86_64/7.2/49ed733f37d2b8779b11c32f56262eff99cb5ef0bed87957829f37e1a3cc3a2a/files
runtime-commit=49ed733f37d2b8779b11c32f56262eff99cb5ef0bed87957829f37e1a3cc3a2a
runtime-extensions=org.freedesktop.Platform.GL.default=16b56ade0efe531eb94a9b0055736f304dd8060d6b3720cf044fed6033396500;org.freedesktop.Platform.VAAPI.Intel=5726d0f2e50f2a759bf1d1aedde620c13f3601e6c2d09e1f81f86f1b449d2f4c;io.elementary.Platform.Locale=61335b088d7892e6294281449abe5d9111473001d663ee6ed9ec693e1a05eca4;org.freedesktop.Platform.GL.default=d077c5f5830e186235bfdaaab9ac3c962f318f77a478324df287fc5e8c5cc468
branch=stable
arch=x86_64
flatpak-version=1.14.2
session-bus-proxy=true
system-bus-proxy=true

[Context]
shared=network;ipc;
sockets=x11;wayland;pulseaudio;fallback-x11;
devices=dri;
filesystems=xdg-download;

[Session Bus Policy]
org.gnome.Epiphany.WebAppProvider=own

[System Bus Policy]
org.freedesktop.GeoClue2=talk

[Environment]
GI_TYPELIB_PATH=/app/lib/girepository-1.0
ALSA_CONFIG_PATH=/usr/share/alsa/alsa-flatpak.conf
XDG_DATA_DIRS=/app/share:/usr/share:/usr/share/runtime/share:/run/host/share
ALSA_CONFIG_DIR=/usr/share/alsa

i tested with the 2.2.0, 2.3.0 and 2.3.1 versions of the extension, an none of them would be mounted in the sandbox.

danirabbit commented 1 year ago

Hrm, that is odd. We do inherit that extension in the manifest here https://github.com/elementary/flatpak-platform/blob/main/io.elementary.Sdk.json#L20

danirabbit commented 1 year ago

Proposed fix here: https://github.com/elementary/flatpak-platform/pull/121

danirabbit commented 1 year ago

@stan-janssen we've resolved the video playback issue in the 7.2 runtime :)

danirabbit commented 1 year ago

@stan-janssen is there anything else holding this back in your opinion? :)

stan-janssen commented 1 year ago

@danirabbit No, I don't think so :-) The few cosmetics can be fixed later I think. It's your call! 🚀