search

elementary / calculator

Calculator app designed for elementary OS
https://elementary.io
GNU General Public License v3.0
80 stars 30 forks source link

Added New Window Prompt #207

Closed rakshit087 closed 3 years ago

rakshit087 commented 3 years ago

Fixes #155

Edited the desktop file to add a 'New Window' prompt when user right clicks.

jeremypw commented 3 years ago

As a hint, its better to create a new branch on your fork and modify that.

rakshit087 commented 3 years ago

Okay I will create a new branch, or shall I remove %U in both the execution commands?

jeremypw commented 3 years ago

Okay I will create a new branch, or shall I remove %U in both the execution commands?

I am just checking that everything works in Flatpak when those parameters are removed. Calculator is a bit unusual - most elementary apps are singletons by default and you have to apply an option in order for a new window to open. However, its best not to allow mission drift for one PR. If other changes that are not essential to this PR are desired they should be made in another PR.

rakshit087 commented 3 years ago

Okay! Let me know if everything works if those parameters are removed, I will make the necessary changes 😁

PS: I am actually new to open-source space, so I don't know how can I change the branch of this push request. I will do so after learning about it 😅

jeremypw commented 3 years ago

I have now confirmed that installing as a Flatpak with the %U removed both in Exec and in the NewWindow action works OK. The new action appears in the dock and in the Applications Menu as expected. So in this case I think we can fix both issues at once - thanks!

rakshit087 commented 3 years ago

Wow! Thank you so much will make a new commit in a min. Commited :))

rakshit087 commented 3 years ago

Okay! How can I do so? Sorry I am kind of new to opensource and stuff. Shall I make it 1.7.1?

jeremypw commented 3 years ago

You need to edit /data/io.elementary.calculator.appdata.xml.in and add another <li></li> entry to release 1.7.1.

Something like <li>Add New Window Desktop Action</li>

rakshit087 commented 3 years ago

Got it, working on it

rakshit087 commented 3 years ago

Done 👍

rakshit087 commented 3 years ago

As a hint, its better to create a new branch on your fork and modify that.

I finally understand this. Will keep this in mind when I make a PR next time 👍 Thank you for merging.