elementary / calculator

Calculator app designed for elementary OS
https://elementary.io
GNU General Public License v3.0
80 stars 29 forks source link

Use GLib.Action for buttons #224

Closed danirabbit closed 2 years ago

danirabbit commented 2 years ago

Use GLib.Action with action targets for buttons.

This avoids conflating the button label with its function and uses the built-in mechanism for activating actions in this way instead of adding a property to a special button subclass

these are probably dumb action names, open to suggestions

jeremypw commented 2 years ago

Looks like a useful cleanup. Haven't tested it yet but a couple of thoughts:

danirabbit commented 2 years ago

@ryonakano any thoughts on which button labels should be translatable that currently aren't?