elementary / calculator

Calculator app designed for elementary OS
https://elementary.io
GNU General Public License v3.0
79 stars 29 forks source link

Make headerbar match all system apps #240

Closed BAProductions closed 1 year ago

BAProductions commented 1 year ago
lenemter commented 1 year ago

Handy is GTK 3 library and Calculator is GTK 4 app. We now have Adwaita in GTK 4, however new header bar is not needed here. Also AFAIK we no longer need show_all in GTK 4.

BAProductions commented 1 year ago

Screenshot from 2023-03-05 21-35-17 Screenshot from 2023-03-05 21-38-47

BAProductions commented 1 year ago

Handy is GTK 3 library and Calculator is GTK 4 app. We now have Adwaita in GTK 4, however new header bar is not needed here. Also AFAIK we no longer need show_all in GTK 4.

Hold on I need to test this on my Eos 7 MV.

TomiOhl commented 1 year ago

Note: if the intention is to make a visually distinguishable headerbar, then it's a design conflict: Calculator was purposefully made flatter, just like some other apps (Mail, Tasks). Other system apps may follow this new direction instead in the future

BAProductions commented 1 year ago

eOS7 System Calculator

Screenshot 2023-03-06 at 10 29 42 AM

eOS7 System Calculator built from source

Screenshot 2023-03-06 at 10 30 16 AM
BAProductions commented 1 year ago

eOS7 System Calculator built from source That I get, But the app still need to respect my custom theme header bar window decoration at most.