elementary / calculator

Calculator app designed for elementary OS
https://elementary.io
GNU General Public License v3.0
79 stars 29 forks source link

Keyboard Support Redo #246

Open BAProductions opened 1 year ago

BAProductions commented 1 year ago

https://github.com/elementary/calculator/pull/242

BAProductions commented 1 year ago

@danirabbit

danirabbit commented 1 year ago

If you're forwarding key events there's no reason to do all that manual key press handling

BAProductions commented 1 year ago

Is there a reason you change the copy and paste logic? Is there maybe an issue we don't know about?

Yes because my entry is set to read only

BAProductions commented 1 year ago

If you're forwarding key events there's no reason to do all that manual key press handling

Let me test this out

BAProductions commented 1 year ago

If you're forwarding key events there's no reason to do all that manual key press handling

Can test my code just so I can make sure the nothing funny happening on my end? & second this how the Gnome Calculator is handal the key events as well

https://gitlab.gnome.org/GNOME/gnome-calculator/-/blob/master/src/math-display.vala#L124

BAProductions commented 1 year ago

All the necessary have been made please review my code.

BAProductions commented 1 year ago

@danirabbit

danirabbit commented 1 year ago

Please be patient. You're not the only person waiting on me for a review :)