elementary / calendar

Desktop calendar app designed for elementary OS
https://elementary.io
GNU General Public License v3.0
131 stars 40 forks source link

Glitches horribly – duplicate events show up, repeat doesn't work #601

Open cshaa opened 4 years ago

cshaa commented 4 years ago

Prerequisites

Describe the bug

I tried to add my university schedule to the Elementary Calendar. I only added events by hand, I didn't import anything. After adding a few, the calendar started glitching terribly, making it impossible to manage my events.

See video.

Download my exported events.

To Reproduce

Steps to reproduce the behavior:

  1. Open calendar
  2. Add an event on Monday
  3. Turn on weekly repeat
  4. See that the event does not repeat
  5. Try to edit the event
  6. A duplicate event appears
  7. What.

Expected behavior

I expected the Calendar app to work properly.

Screenshots or screen recordings

Logs

The only error log I saw was this one:

** (io.elementary.calendar:3636): CRITICAL **: 11:28:29.710: Store.vala:379: Error from source 'Narozeniny a v?ro??': Cannot invoke method; proxy is for a well-known name without an owner and proxy was constructed with the G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START flag

But this is probably unrelated. I think it was caused by me starting the Calendar with a different locale. ”Narozeniny a výročí” is Czech for “Birthdays and aniversaries”. The glitching appeared even before I switched locale and this error log stopped appearing once I restarted the app with the new locale.

Platform Information

elementary OS 5.1.7 Hera

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/94970698-glitches-horribly-duplicate-events-show-up-repeat-doesn-t-work?utm_campaign=plugin&utm_content=tracker%2F60388692&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F60388692&utm_medium=issues&utm_source=github).
mcclurgm commented 4 years ago

There seem to be a couple issues here, and I'm not sure if they're related. Unfortunately, I can't get any of them to appear on my machine. I've tried creating the events myself, and they all behave normally. They repeat as I expect. Also, when I edit the events I imported, they don't produce any duplicates and work normally. Can you recreate the problem on your computer and give us more specific instructions? Also, what type of calendar are you saving to—local, Google, other CalDAV? I'd appreciate any info you could give me here, since I don't know how to help you without seeing the issue myself.

Here's one thing I can say for sure though: there's something wrong with the events. When I import them into Evolution, the one I see ([Fyzika V]) doesn't repeat there either. I'm not sure what's going on. Based on this, I'm a little worried that the behavior with non-appearing recurrences and duplicating events may not be our fault. Of course, creating the issues in the first place is our fault, though. I'll see if I can look into it any more.

One more note: I wonder if the duplicated event is somehow related to #519? Since then, we create a duplicate of an event in our database when you save changes, then remove the old one.

cshaa commented 4 years ago

This is the first time I've used the Elementary Calendar, so I started with an empty calendar without any events. I created local events, I don't have any synchronization turned on, just the default local calendar (named “Osobní” – ie. Personal). I can try to delete all the events and start anew to see if I can replicate the issue.

If I had to make a wild guess... I'm on a low-end laptop and I created the events in a rapid succession while having multiple programs open and near 100% CPU usage, so it might be caused by some kind of race condition. Maybe the calendar tried to write multiple events at once into the database and something broke? But that's just a guess, probably I'm totally off 😁️