search

elementary / calendar

Desktop calendar app designed for elementary OS
https://elementary.io
GNU General Public License v3.0
130 stars 39 forks source link

694: Replace deprecated function call. Add null check. #716

Closed jpgleeson closed 2 years ago

jpgleeson commented 2 years ago

Update deprecated function call and gate behind null check. #694

jeremypw commented 2 years ago

The code appears to make sense but not sure how to check. An existing event linked to my Google account did not show my Google avatar or the local one (just the fallback first letter one). That said,Mail is only showing fallback avatar at the moment as well.

jeremypw commented 2 years ago

There is some extraneous white space at the end of line 111 causing lint failure.

jpgleeson commented 2 years ago

Linting fixed in 14acae1.

I believe it won't show the correct remote avatar until we set up a backend to fetch and store these avatars to the local machine similar to the Mail backend for Local and Gravatar. I've been tipping away at a PR for this but it won't be for some time.