search

elementary / calendar

Desktop calendar app designed for elementary OS
https://elementary.io
GNU General Public License v3.0
130 stars 39 forks source link

Use assert_true instead of assert in tests #747

Closed mcclurgm closed 2 years ago

mcclurgm commented 2 years ago

What it says on the tin. For unit tests, you're supposed to use GLib.assert_true instead of GLib.assert, which may be disabled by compilation flags. See https://docs.gtk.org/glib/testing.html.

mcclurgm commented 2 years ago

Hmm, this CI action really doesn't want to run. Do you have any idea why it wouldn't even show up in the Actions tab? I'm not familiar with Github actions, so I'm not sure where to look.

davidmhewitt commented 2 years ago

CI probably didn't run due to the issues GitHub has been experiencing in the last couple of days. I've just pushed a completely blank commit, to trigger it. Looks to be running now

mcclurgm commented 2 years ago

Thanks! Didn't think of that 😅️