search

elementary / calendar

Desktop calendar app designed for elementary OS
https://elementary.io
GNU General Public License v3.0
130 stars 39 forks source link

Support evolution data server 3.45+ / libsoup-3.0 / geocode-glib-2.0 #756

Closed bobby285271 closed 1 year ago

bobby285271 commented 2 years ago

Not sure if this is really an issue that should be resolved before/during GNOME 43 cycle or just because of me didn't packaged everything properly yet. Building this with evolution data server 3.45.1 fails for me and I think maybe it is caused by libsoup-2.4 clashes with libsoup-3.0, here is the full log:

https://gist.github.com/bobby285271/1a19d13bab9146d0824de0e2a82aa5ac

P.s.: I also mentioned geocode-glib-2.0 in the title as it is built against libsoup-3.0.

Actually I am trying to port this but stuck on this line:

https://github.com/elementary/calendar/blob/2b30b8313591336d65cf59e3f29656f5ebe9be2c/plugins/CalDAV/CalDAVBackend.vala#L76

Is replacing it with dup_uri only possible on 3.46 due to this? Was getting:

../plugins/CalDAV/CalDAVBackend.vala:77.23-77.36: error: `E.SourceWebdav.dup_uri' is not available in libedataserver-1.2 3.45.1. Use libedataserver-1.2 >= 3.46
   77 |             var uri = webdav.dup_uri ();
      |                       ^~~~~~~~~~~~~~
decathorpe commented 2 years ago

Hum, yes, calendar is also broken with e-d-s 3.45.1 on Fedora. It appears that I forgot to file a bug about this one, I filed tickets for all the others. Weird.

decathorpe commented 2 years ago

Building this with evolution data server 3.45.1 fails for me and I think maybe it is caused by libsoup-2.4 clashes with libsoup-3.0, here is the full log:

I'm seeing similar (or the same) build problems on Fedora. This means that something is pulling in libsoup 2.4 development headers. Turns out, the culprit is calendar itself (or at least, one of the culprits): https://github.com/elementary/calendar/blob/master/meson.build#L31

I think this needs a similar conditional (i.e. if e-d-s >= 3.45.1, depend on libsoup-3, else, depend on libsoup-2) to the ones you submitted for other projects, and it might just work (maybe with minor code adaptations for changed APIs, like the Soup.URI removal).

bobby285271 commented 2 years ago

I finally managed to build and launch the app, I think we will at least need:

bobby285271 commented 2 years ago

Looks like my previous testing is done in an improper way, it looks like with #758 applied and everything GNOME 43.rc and the libchamplain MR and Eds 3.46 (it's out!) both wingpanel-indicator-datetime and calendar does not show any date numbers :disappointed:

bobby285271 commented 2 years ago

Ah it looks like I resolved https://github.com/elementary/calendar/issues/756#issuecomment-1249990402 with https://github.com/bobby285271/calendar/commit/7f3a4be3d26f0656b40fcd326c11e622533d23d0 so probably that is not really related to the e-d-s bump (I still not sure what happened though) :see_no_evil:

meisenzahl commented 1 year ago

Should be closed by https://github.com/elementary/calendar/issues/756