search

elementary / calendar

Desktop calendar app designed for elementary OS
https://elementary.io
GNU General Public License v3.0
130 stars 39 forks source link

Fix meson warning for run_command #762

Closed turbobastii closed 1 year ago

turbobastii commented 1 year ago

Since I am already fixing the other repos with this issue, I thought I might do it here aswell.

TLDR: meson will change the default behaviour of run_command and displays that as a warning when building. See: https://github.com/mesonbuild/meson/issues/9300

image

tintou commented 1 year ago

Don't we want it to be true?

turbobastii commented 1 year ago

Well it was false implicitly by default, but if you think it would make more sense if it was true, I can of course change it.

eli-schwartz commented 1 year ago

Well it was false implicitly by default

If the implicit default was generally good, then we (Meson) would not have deprecated it in the hope of eventually changing the default. :)

When adding an explicit value, it is wisest to consider what that value would be best served by being, rather than just explicating the default purely to quell the warning.

...

i.e. It's quite likely that if the command failed, the build is broken and will error out for quite mysterious reasons slightly later on -- best to validate it early...

turbobastii commented 1 year ago

Very well put, thank you. I changed it accordingly.