search

elementary / code

Code editor designed for elementary OS
https://elementary.io
GNU General Public License v3.0
482 stars 114 forks source link

Properties/Behaviour dialog should make clear settings may be overridden by .editorconfig #1229

Open jeremypw opened 1 year ago

jeremypw commented 1 year ago

What Happened?

In the Properties/Behaviour dialog the tab width was changed but this had no effect on the document being edited. This was because this dialog changes the fallback global app setting but this may be overridden by settings in .editorconfig.

This behaviour might confuse a new user.

Steps to Reproduce

  1. Open a project where the .editorconfig has a global tab width setting (e.g. Files)
  2. Open a document with tabs
  3. Change the global app tab setting via AppMenu/Properties/Behaviour/Tabs
  4. The document is unaffected both with respect to existing and new content.

Expected Behavior

The dialog should make it clearer what the settings actually change. Ideally the dialog should allow display and modification of the editorconfig settings as well.

OS Version

7.x (Early Access)

Software Version

Latest release (I have run all updates)

Log Output

No response

Hardware Info

No response

jeremypw commented 1 year ago

Note that a warning is revealed and the appropriate controls disabled in the tab popover in the format bar, but not in the preferences dialog of the AppMenu.