search

elementary / code

Code editor designed for elementary OS
https://elementary.io
GNU General Public License v3.0
479 stars 113 forks source link

Unable to rename folders in project #1486

Open ThatTonybo opened 5 days ago

ThatTonybo commented 5 days ago

What Happened?

Attempted to rename a folder in my project's hierarchy by right-clicking and hitting "Rename". However nothing happens, the context menu disappears and nothing comes up, no field to edit the name or anything like it. This doesn't happen if you right-click and attempt to rename a file, however.

Steps to Reproduce

  1. Opened a project with multiple folders (the project in specific has a git repository)
  2. Right-clicked on a folder and clicked "Rename"
  3. Context menu will disappear, and no field/way of renaming the folder will appear

Expected Behavior

A field will appear to edit and rename the folder, similar to how right-clicking to rename a file works

OS Version

7.x (Horus)

Session Type

Classic Session (X11, This is the default)

Software Version

Latest release (I have run all updates)

Log Output

Launching the application with G_MESSAGES_DEBUG=all io.elementary.code produces the following log when right-clicking a folder and selecting "Rename":

** (io.elementary.code:43376): CRITICAL **: 23:13:01.930: granite_widgets_source_list_tree_start_editing_item: assertion 'item.selectable' failed

Hardware Info

Running in a Hyper-V virtual machine, unsure if this would affect such an action however

colinkiama commented 5 days ago

I suspect that a regression was caused by https://github.com/elementary/code/pull/1465

zeebok commented 2 days ago

Is this definitely 7.1, or is it 8? On my local 7.1 install I can rename a folder but I want to be sure

ThatTonybo commented 1 day ago

Is this definitely 7.1, or is it 8? On my local 7.1 install I can rename a folder but I want to be sure

Definitely is 7.1, fresh install off the website ISO

jeremypw commented 1 day ago

I could not reproduce this with the master branch on OS7.1. I'll try with the released version (v 7.4.0).

jeremypw commented 1 day ago

I could not reproduce with this with v7.4.0 either. I tried OS7.1 on bare metal and OS8 in a Boxes VM. Note that pressing Enter at the rename text entry will end the rename not delete the selected text.

jeremypw commented 1 day ago

There are some critical warnings produced in the terminal however so it is worth producing a PR to silence those.