search

elementary / code

Code editor designed for elementary OS
https://elementary.io
GNU General Public License v3.0
481 stars 114 forks source link

No message to user that saving fails when disk is full #693

Open davidak opened 5 years ago

davidak commented 5 years ago

I tried to save a file and thought it was saved, since i got no message that saving failed. So i closed the editor, which lead to data loss!

As i started code from console, i got this errors:

(io.elementary.code:7445): dconf-WARNING **: 16:50:32.099: failed to commit changes to dconf: GDBus.Error:org.gtk.GDBus.UnmappedGError.Quark._g_2dfile_2derror_2dquark.Code12: Failed to write file “/home/davidak/.config/dconf/user.6ICC5Z”: write() failed: No space left on device
[WARNING 16:50:40.188720] Document.vala:834: Cannot create backup copy for file "configuration.nix": Error splicing file: No space left on device
[WARNING 16:50:40.197186] Document.vala:477: Cannot save "configuration.nix": Error writing to file: No space left on device
[WARNING 16:50:42.616458] Document.vala:477: Cannot save "configuration.nix": Error writing to file: No space left on device

Please also show it to users of the GUI and warn them to close the editor in such a case!

Code 3.1.1 on NixOS 19.03.173165.55b8860aa20

fluks commented 5 years ago

I confirm this happens. I also tried to save a file overwriting a file to which I didn't have write permission and it's not visible that save failed. Document's filename was also changed to this new filename.

Looking at the code, error message won't be shown in any case if saving fails.

I could work on this and add an error message and not change the filename of the document.