search

elementary / contractor

A desktop-wide extension service used by elementary OS
https://elementary.io
GNU General Public License v3.0
31 stars 11 forks source link

meson regression: contract directory no longer installed #26

Closed decathorpe closed 4 years ago

decathorpe commented 6 years ago

The meson equivalent of install (DIRECTORY DESTINATION ${CMAKE_INSTALL_FULL_DATAROOTDIR}/contractor) is missing - so the contracts directory is no longer created upon installation.

CameronNemo commented 5 years ago

Can't this be handled by packaging? In Void an empty directory will be removed without some packaging hooks anyway.

decathorpe commented 5 years ago

@CameronNemo I am handling this in packaging now.

It's just best practice on fedora to have the main package own the directory structure it provides for its "children". In this case, contractor expects other packages to put their contracts in this directory, so contractor should create the directory and the contractor package should own it.

This has the nice benefit that - when removing contractor and all contracts - everything is cleaned up nicely, and no empty directories are left behind, cluttering the system.

decathorpe commented 5 years ago

Will this be reintroduced to meson, or will I have to keep doing this in packaging?

decathorpe commented 4 years ago

Alright, after discussing a similar issue in switchboard, we decided that it's probably easiest to deal with this in RPM packaging directly.