search

elementary / default-settings

Default settings for elementary OS
GNU General Public License v3.0
39 stars 28 forks source link

Epiphany find in page close button not consistent #122

Closed D0J0P closed 5 years ago

D0J0P commented 5 years ago

In other apps like Code and Terminal, the Find in Page button is on the headerbar. Pressing it opens the Find in Page function, and pressing it again closes it.

Because there's no button like this in Epiphany(which is fine), there's an x as a close button. But it's on the right instead of the left.

The left is where the close button is for everything like windows and tabs. Maybe it should be there, or is there an even better way than that?

peteruithoven commented 5 years ago

This might be an issue for the Epiphany issue queue? https://gitlab.gnome.org/GNOME/epiphany/issues

I noticed a related issue: https://gitlab.gnome.org/GNOME/epiphany/issues/4

D0J0P commented 5 years ago

I posted it here because I know elementary has adapted most of Epiphany to it's own HIG design, so I thought this would be within that scope.

D0J0P commented 5 years ago

Actually, that related issue you showed me was closed 2 months ago. Has Epiphany for eOS been updated for that change?

peteruithoven commented 5 years ago

I might be misunderstanding you, but that issue still seems open? Screenshot from 2019-07-31 09-42-32@2x

D0J0P commented 5 years ago

Nevermind, I read the closed issues on that issue. Now we just have to wait until the related issue is closed. Hopefully it'll affect the find in page close button.