elementary / default-settings

Default settings for elementary OS
GNU General Public License v3.0
39 stars 28 forks source link

Epiphany print window not native to elementary #125

Closed D0J0P closed 5 years ago

D0J0P commented 5 years ago

Settings > Print Screenshot from 2019-07-26 20 15 50

peteruithoven commented 5 years ago

Again, please stop opening these issues here. Epiphany is a external project: https://gitlab.gnome.org/GNOME/epiphany/

We do patch / change it with some patches, but those are managed in the os-patches repo. See: https://github.com/elementary/os-patches/tree/epiphany-browser-bionic-patched https://github.com/elementary/os-patches/compare/epiphany-browser-bionic...epiphany-browser-bionic-patched

Actually, why wouldn't that be the "native" print window? Except for it being black this is the window I get when initiating print from the Photos app: Screenshot from 2019-07-27 10-02-00@2x

This is the window I get from the Document viewer (also a external project): Screenshot from 2019-07-27 10-04-14@2x

There will always be a difference with the System Settings > Printers screen, just like there is a difference between the file selector you use in specific apps when opening files and the Files app.

D0J0P commented 5 years ago

It's not native because it's a piece of UI from Gnome. I know they patched Epiphany to at least look like a native first party app in elementary, and you can see the UIs aren't 100% identical. The new tab button is on the tab bar, and the tab bar is always on display. I thought I'd report this to try to have the settings/print screen go along with elementary's HIG as well.

I didn't know Photo's print screen was the same as well. I know that app was a fork of Shotwell, but I thought it's UI was fully adapted to eOS' HIG.

The Document Viewer is Evince, a Gnome app. IMO, I think every app that comes out of the box should look fully native, and not have any Gnome bits left in them.

Would os-patches repo be a better place to report the print screen in apps and Epiphany's settings screen?

peteruithoven commented 5 years ago

Yeah the patches repo would be a better place.

Photos is currently a elementary OS specific application: https://github.com/elementary/photos/