elementary / default-settings

Default settings for elementary OS
GNU General Public License v3.0
39 stars 28 forks source link

Epiphany should only accept first party cookies #127

Closed moonmehta closed 4 years ago

moonmehta commented 5 years ago

Forgive me for filing this bug here as I couldn't find any repo for the slightly-modified Epiphany being shipped by elementary.

Third party cookies are often used for tracking and which is why Safari and Brave have turned them off by default. Most websites seem to work fine with the setting off in Firefox as well. For the strong privacy stance that elementary takes, third party cookies should be off by default instead of its current setting (below). screenshot from 2019-02-27 07-11-46

peteruithoven commented 5 years ago

Thanks for the report. This isn't the right repo though, please see: https://gitlab.gnome.org/GNOME/epiphany/blob/master/CONTRIBUTING.md

In a future release of the About plug there will be an option for Epiphany (see PR) linking to:

Since we can't move issues to gitlab I'm closing this issue.

cassidyjames commented 5 years ago

@peteruithoven since this issue is about default settings of Epiphany in elementary OS, it does belong here. We change certain settings downstream in our OS.

moonmehta commented 5 years ago

Not to press, but it'd be great to have this by default in the Juno 5.1 release. I've never coded, but would be happy to file a PR given apt guidance.

cassidyjames commented 5 years ago

@uncertainquark I've moved this to the os-patches repo. Epiphany patches are in this branch: https://github.com/elementary/os-patches/tree/epiphany-browser-bionic-patched

cassidyjames commented 5 years ago

As on the other issue, I was misunderstanding this, and didn't realize you were just talking about the existing setting. default-settings is actually the right place. I'll point you in the right direction in a sec. :smile:

cassidyjames commented 5 years ago

@uncertainquark Epiphany overrides start here: https://github.com/elementary/default-settings/blob/848a8bfc1d3bae9945f51498d8b9ae2cc0d39911/overrides/default-settings.gschema.override#L98

Some may be self-explanatory, but if you open up dconf-editor on your elementary desktop, browse to /org/gnome/epiphany/, then toggle the settings, you should see what changes and to what values. You'd simply need to edit that file and submit a PR with the edit to this repo and then we can test and decide if it's something we should actually turn on.

moonmehta commented 5 years ago

Hey, I've created a pull request. Will get to the remaining two issues after I see how the full cycle for this one goes!