search

elementary / default-settings

Default settings for elementary OS
GNU General Public License v3.0
39 stars 28 forks source link

Defaulting to multitouch physical clicking can be unwanted on touchpads with touchpad area indications #183

Open zach-hopkins opened 4 years ago

zach-hopkins commented 4 years ago

Prerequisites

Describe the bug

Right click on a laptop trackpad basically never works out of the box. I have a small sample size (4 notebook/laptop computers - Lenovo, Clevo, x2 Dell), however, right clicking worked on zero of them until I changed the touchpad settings to "touchpad areas". Any thought of potentially making "Touchpad Areas" default?

If applicable, add screenshots or screen recordings to help explain your problem.

Expected behavior

Out of the box right click functionality on laptop trackpads

Platform Information

OS: Elementary

Please check what applies: -->

danirabbit commented 4 years ago

When using "Hardware default" does two-finger tap work as a right click?

zach-hopkins commented 4 years ago

When using "Hardware default" does two-finger tap work as a right click?

Yes it does.

danirabbit commented 4 years ago

I think that sounds like this is working as intended then. If your hardware default is two-finger tap and that’s working as described, I’m not sure this is a valid report except to say that you prefer something other than your hardware default which is why there is a setting :)

@cassidyjames any thoughts about this?

zach-hopkins commented 4 years ago

Laptop trackpads i've tested have distinct 'click' areas - intention is for hard right-click/left-click.

cassidyjames commented 3 years ago

Hold on, I think two different things are being conflated. Taps and physical clicking are treated completely separately by LibInput, so one doesn't affect the other.

Two-finger tap (tapping on the surface without physically clicking down) for secondary click is always enabled as long as "Tap to click" is enabled, which it is out of the box in elementary OS. elementary OS also defaults to "Multitouch" physical clicking by design, i.e. using two fingers to click down on and depress a trackpad. I think we chose this default because otherwise it can be confusing why two-finger tapping works but two-finger clicking only works on certain hardware.

That said, I would not be super opposed to trying "Hardware default" physical clicking and seeing if folks generally find it does the right thing on their hardware. This is super hardware-dependent, though, and I believe that data lives in LibInput itself.

cassidyjames commented 3 years ago

@zach-hopkins for clarity, does right-clicking work as you'd expect (phyiscally depressing the bottom-right area of the trackpad) when you choose "Hardware default" for physical clicking?

zach-hopkins commented 3 years ago

Yes it did, on all four devices.

On Tue, Aug 25, 2020, 11:55 AM Cassidy James Blaede < notifications@github.com> wrote:

@zach-hopkins https://github.com/zach-hopkins for clarity, does right-clicking work as you'd expect (phyiscally depressing the bottom-right area of the trackpad) when you choose "Hardware default" for physical clicking?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/elementary/default-settings/issues/183#issuecomment-680209730, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKNWCC7I5WN3JFPOFWIN76LSCQCJPANCNFSM4OWC3KIA .

cassidyjames commented 3 years ago

@danrabbit so we could try out "Hardware default" here as a default, though I suspect it will be a change that some don't like; for example, on Pinebook Pro, the "hardware default" from LibInput is for touchpad areas, even though it has no indication of those areas on the trackpad. I believe the same thing was often the case for System76 and Dell hardware as well—maybe LibInput defaults to areas if there's no data?