Make GSettings Overrides specific to Pantheon session

[worldofpeace]

Fixes #81

This is a really nice feature and makes these overrides much better to use as they won't conflict with default GNOME specifically.

[cassidyjames]

@worldofpeace ha, I thought we did this long ago for some reason. Seeing as this is for default settings, do you know the best way to test this before merging?

[worldofpeace]

@worldofpeace ha, I thought we did this long ago for some reason. Seeing as this is for default settings, do you know the best way to test this before merging?

Yes, I do know the best way to test this.

https://github.com/elementary/default-settings/pull/97#pullrequestreview-168914317

debuild -us -uc -j -b sudo dpkg -i ../*.deb

And I guess a reboot is a safe way to check if everything is in order.

If it's a fail you'll likely notice right away the session and greeter looking very very broken. If that's not the case you can assume it is a success, but you could also check the default value of a certain key https://github.com/elementary/default-settings/blob/master/overrides/default-settings.gschema.override.in#L11 and see if it's the same as specified in the override.

[cassidyjames]

@worldofpeace ah so I see an issue here: the greeter and installer sessions are not considered Pantheon, I think. When I apply this, the session works fine but the greeter session has the wrong fonts and icons. I assume the same thing would be true for the Installer session.

[worldofpeace]

@worldofpeace ah so I see an issue here: the greeter and installer sessions are not considered Pantheon, I think. When I apply this, the session works fine but the greeter session has the wrong fonts and icons. I assume the same thing would be true for the Installer session.

Perhaps I can make glib happy enough with the greeter and installer by setting XDG_CURRENT_DESKTOP to pantheon. example https://gitlab.gnome.org/GNOME/glib/-/blob/master/gio/tests/gsettings.c#L2797

[worldofpeace]

@worldofpeace ah so I see an issue here: the greeter and installer sessions are not considered Pantheon, I think. When I apply this, the session works fine but the greeter session has the wrong fonts and icons. I assume the same thing would be true for the Installer session.

Perhaps I can make glib happy enough with the greeter and installer by setting XDG_CURRENT_DESKTOP to pantheon. example https://gitlab.gnome.org/GNOME/glib/-/blob/master/gio/tests/gsettings.c#L2797

I tried this and it didn't work :frowning_face: It's possible that I just didn't do it right (I tried to put it in main of greeter), but I not really sure to do about the greeter and installer.

[worldofpeace]

Ugh, I feel like this pull request is cursed :rofl:

[davidmhewitt]

I've opened a PR for greeter that I've tested works in conjunction with this branch. I've also opened one for installer that I believe will work but haven't had the chance to test yet as I'm working on my Pinebook Pro and we don't build distinst/installer for ARM.

[worldofpeace]

I've opened a PR for greeter that I've tested works in conjunction with this branch. I've also opened one for installer that I believe will work but haven't had the chance to test yet as I'm working on my Pinebook Pro and we don't build distinst/installer for ARM.

I guess you mean that setting XDG_CURRENT_DESKTOP worked.

[worldofpeace]

I can test with both since I believe I have the installer packaged somewhere

[decathorpe]

I've tested this on Fedora, and I can confirm that it works as expected (overrides applying to the elementary greeter and Pantheon session, but not to, for example, a GNOME session). The elementary installer is not packaged for Fedora yet, so I was not able to test this there, though.

[worldofpeace]

@danrabbit was like :shipit: