search

elementary / default-settings

Default settings for elementary OS
GNU General Public License v3.0
39 stars 28 forks source link

AccountsService: Add PrefersAccentColor to users #190

Closed cassidyjames closed 3 years ago

cassidyjames commented 3 years ago

Will fix #175. Open to feedback.

My reason for having 0 equal "No Preference" while also having blue is because it seemed the most flexible if we wanted to change how the accent color stuff worked down the line, without hardcoding the default to blue. But maybe this is overthinking it.

cassidyjames commented 3 years ago

Currently unsure how we want to refer to the "generic" names, but mapping them to an int/enum means we can tweak them in the comment later without affecting anything code-wise—so probably best not to get too hung up on it.

danirabbit commented 3 years ago

@cassidyjames this seems reasonable to me, should this be marked ready for review?