elementary / dock

A quick app launcher and window switcher for Pantheon and elementary OS
https://elementary.io
GNU General Public License v3.0
88 stars 23 forks source link

App 'open' indicators don't follow accent colour #100

Closed kdwk closed 2 years ago

kdwk commented 3 years ago

What Happened

Colour of 'open indicators' of apps do not match accent colour set in Settings. They seem to just have the 'strawberry' colour.

Expected Behavior

The indicators follow the accent colour I set in Settings

Steps to Reproduce

  1. Set an accent colour other than 'strawberry'
  2. Observe the indicators Screenshot from 2021-05-01 07-16-32

Logs

Platform Information

Screenshot from 2021-05-01 07-12-40

meisenzahl commented 3 years ago

Indicator dot color is hardcoded in docker/plank.theme to red:

...
#The color of the urgent indicator or badge.
BadgeColor=237;;83;;83;;255
...

https://github.com/elementary/stylesheet/blob/master/src/plank/dock.theme#L59-L60

cassidyjames commented 3 years ago

@meisenzahl that's the badge color which is used for the numbered badges, but not for open window indicators.

I've added this to the 6.0 Odin project as it's a minor visual regression caused by the new stylesheet, but we want to solve it before stable.

Akryum commented 3 years ago

Also it seems the additional background put on the focused window is not present anymore.

eOS 5:

image

eOS 6:

image

hanaral commented 3 years ago

@Akryum The focus backdrop was removed intentionally very early in the Odin Early Access, unlike the dots' colouring (which isn't intentional)

Akryum commented 3 years ago

Why was it removed? 🤨

hanaral commented 3 years ago

@Akryum #60