elementary / dock

A quick app launcher and window switcher for Pantheon and elementary OS
https://elementary.io
GNU General Public License v3.0
88 stars 23 forks source link

Missing GSettings post install script #140

Closed rbreaves closed 10 months ago

rbreaves commented 2 years ago

What Happened?

I apologize if this is the wrong place - I understand it may be better to post this over at ClearLinux, but am hoping for some input here as well.

I get this error after compiling for ClearLinux. Pretty sure it is irrelevant that I am also compiling a different branch, I use this same branch already on Ubuntu.

Another instance, but nothing helpful. https://answers.launchpad.net/plank/+question/663609

[ERROR 12:43:23.351257] [Utils:42] GSettingsSchema 'net.launchpad.plank' not found
Trace/breakpoint trap (core dumped)

Steps to Reproduce

  1. Install ClearLinux
  2. Install dependencies
    
    sudo clone https://github.com/elementary/granite.git
    sudo swupd bundle-add devpkg-libgee
    sudo swupd bundle-add devpkg-gtk3                                 # (383mb)
    sudo swupd bundle-add devpkg-gobject-introspection (1.58mb)
    meson build --prefix=/usr
    cd build
    ninja

git clone https://github.com/lainsce/dock.git git checkout dock-monochrome-indicators sudo swupd bundle-add dev-utils # (533mb) sudo swupd bundle-add devpkg-vala sudo swupd bundle-add wget wget https://download-ib01.fedoraproject.org/pub/fedora/linux/releases/34/Everything/x86_64/os/Packages/b/bamf-devel-0.5.5-1.fc34.x86_64.rpm sudo rpm -ivh --nodeps ./bamf-devel-0.5.5-1.fc34.x86_64.rpm sudo swupd bundle-add devpkg-libwnck3 # (1.73mb) wget https://download-ib01.fedoraproject.org/pub/fedora/linux/releases/34/Everything/x86_64/os/Packages/g/gnome-menus-devel-3.36.0-4.fc34.x86_64.rpm sudo rpm -ivh --nodeps ./gnome-menus-devel-3.36.0-4.fc34.x86_64.rpm

3. Run normal meson and ninja install

meson build --prefix=/usr cd build ninja test ninja install plank



### Expected Behavior

Normal dock popping up

### OS Version

Other Linux

### Software Version

Compiled from git

### Log Output

_No response_

### Hardware Info

_No response_
davidmhewitt commented 2 years ago

Thanks to some extra information provided at https://github.com/elementary/default-settings/issues/267#issuecomment-1085732031 , this is probably due to a missing meson post install script that compiles the GLib Settings Schemas.

It isn't necessary for us to provide this since the debian packaging automatically handles compiling settings schemas when they are changed, so this doesn't affect plank when it is installed from a debian package.

However, we provide this post install script in most other repositories as it usually helps with development, and clearly helps packagers for other distros, so we should provide it here too. This would need the post install script adding (example here: https://github.com/elementary/appcenter/blob/master/meson/post_install.py), and the necessary line in the meson.build file. For example: https://github.com/elementary/appcenter/blob/b7efcd0b56dd3d78558eca39600bb7d9f6879d44/meson.build#L70

eli-schwartz commented 2 years ago

This seems to be fixed in the from scratch rewrite: 67dd5d6cf55a8f50661d332383a2ca2859fb4029

Note however that you could do this directly in Meson using https://mesonbuild.com/Gnome-module.html#gnomepost_install

You would need to bump the minimum version of Meson to 0.57, currently you don't specify a minimum at all (but you use features from 0.49.0).

bobby285271 commented 2 years ago

Yeah for me gnome.post_install() also has the advantage that we will no longer need to open tons of issues like https://github.com/elementary/granite/issues/584 when GTK5 comes :rofl:

danirabbit commented 10 months ago

Closing since this is fixed in main