Feature: Show keyboard shortcuts in menu

[davidak]

Problem

I accidentally pressed a keyboard shortcut (c) and lost all my work.

Proposal

Other menus show keyboard shortcuts, like the program Photos.

To be consistent, they should be displayed here too.

Prior Art (Optional)

No response

[jeremypw]

Which app and which shortcut caused loss of work? Any irreversibly destructive action should have some kind of warning.

[davidak]

@jeremypw i often have 500+ tabs open in Chromium and when i right click on the icon in the dock and press C, it triggers "Close All" which closes every window after another, so when i open the program again, it does not restore all my tabs! Here are more details and a video: https://github.com/elementary/dock/issues/147

@danrabbit is this issue also addressed by the rewrite?

[jeremypw]

@davidak Could you check your settings on Chromium to ensure that the "On Start Up" setting is to continue where you left off? I just tried this and the open tabs were saved even when closed using the context menu on the dock and the mnemonic "C". I agree however that there should be some indication what the shortcuts are on the dock menus. It also is unusual to have an unmodified key as an accelerator. ( I am running EOS7 btw). It seems odd to have keyboard shortcuts anyway as there is no obvious way to operate the dock using the keyboard otherwise.

[davidak]

Could you check your settings on Chromium to ensure that the "On Start Up" setting is to continue where you left off?

yes. it works when i close the browser using it's menu

[danirabbit]

Thanks for your report! We're doing a complete rewrite of the dock based on our recent UI study and this particular issue isn't able to be reproduced in the new version of the dock