search

elementary / dock

A quick app launcher and window switcher for Pantheon and elementary OS
https://elementary.io
GNU General Public License v3.0
87 stars 24 forks source link

Add support for Unity badges #193

Closed danirabbit closed 7 months ago

danirabbit commented 8 months ago

Fixes #74 Fixes #201

Tested with Granite Demo. The DBus class is taken almost directly from Plank with code style fixes.

Screenshot from 2023-11-19 11 49 02

jeremypw commented 8 months ago

This worked with granite-demo (and App Center notifications) but not with granite-7-demo. However, the existing Plank dock did work with granite-7-demo.

leolost2605 commented 7 months ago

I'm not sure but I think this might be a problem with granite demo. The application id set there is io.elementary.granite.demo which is used by granite to send the unity entry but the desktop file is io.elementary.granite-7.demo which is what gala and therefore dock know about. Plank only works because it adds a second app for the unity entry which has no icon etc. I'm not sure though what the preferred behavior here is. IMO it's better to hide it entirely (like it's done in this PR)

danirabbit commented 7 months ago

Yeah I think the correct behavior is to make sure we're getting a consistent ID so that apps can't pretend to be other apps etc