Styling: Make Indicators Monochromatic

[lainsce]

Made them monochromatic, and they adapt to any themes! Fixes #30; fixes #100.

Light:

Dark:

[lainsce]

See updated OP, I could make them monochromatic and contrasty!

[matfantinel]

This would fix #30 , thank you!!!

[lainsce]

Good to go!

[fabiozaramella]

@lainsce Can you resolve the conflicts please?

[lainsce]

Will do.

[lainsce]

There we go.

[lainsce]

Because of the decision to go with #85 I am closing this.

[meisenzahl]

@cassidyjames this is the pull request you were looking for. Is this your preferred way?

If there are still adjustments to be made, I'm happy to work on it.

[cassidyjames]

@meisenzahl yes I think unless/until we decide to drop the open indicators completely, we should fix them to be monochrome at least. :smile:

[cassidyjames]

@JoseExposito I think that's actually intended; Plank has a CascadeHide property set to true in the elementary theme; it's described:

Whether background and icons will unhide/hide with different speeds. The top-border of both will leave/hit the screen-edge at the same time.

We should double-check whether this actually changed the behavior from master, or whether it's just more obvious with the higher contrast indicator color.

[JoseExposito]

@cassidyjames it doesn't happen in master:

https://user-images.githubusercontent.com/1335948/125505078-14003e9d-96aa-40cf-bdef-e2a54788e366.mp4

I believe this is because how indicator are drawn now, but @lainsce will know better.

[cassidyjames]

@JoseExposito ah yeah, it looks like the indicators moved from being attached to the icons to animating on their own or something. I agree the behavior in master looks better; we should resolve that.

[danirabbit]

Honestly this seems like a hack. It's trying to work around theme sizing values. If we're going to ignore values, we should just ignore them, not transform them in an unpredictable way

[lainsce]

If I remember correctly, I had to make some changes to some values to make the indicator more visible, and not just a 2×2 dot that hugs the bottom part of the screen as it was when it had the glow look when I removed said glow look.

All in all, if anyone wants to do something better than this, go ahead.

[cassidyjames]

So the root cause seems to be here:

https://github.com/elementary/dock/blob/9150dd81bc3741d76eefee54993d7fc89d8d0d03/lib/DockRenderer.vala#L1009-L1015

Plank is using the deprecated Gtk.StyleContext.get_background_color (). This should probably be updated to use some other method of getting the accent color.

[Marukesu]

Plank is using the deprecated Gtk.StyleContext.get_background_color (). This should probably be updated to use some other method of getting the accent color.

I tried using Gtk.StyleContext.lookup_color (), some examples using master dots:

• with theme_selected_fg_color:

Light Mode	Dark Mode

• with theme_selected_bg_color:

Light Mode	Dark Mode

the yellows dots are urgent dots, where i used warning_color.

[BAProductions]

If I remember correctly, I had to make some changes to some values to make the indicator more visible, and not just a 2×2 dot that hugs the bottom part of the screen as it was when it had the glow look when I removed said glow look.

All in all, if anyone wants to do something better than this, go ahead. I have take a look at what I done!!!! https://github.com/elementary/dock/pull/130

[rbreaves]

Whether this PR or the #130 they should probably both parameterize the indicator glow to be on or off. Having said that I have been enjoying this PR for months now.

[danirabbit]

Thanks for this branch! We're doing a fresh rewrite and this pull no longer applies to the new main