elementary / feedback

GitHub Issue Reporter
https://elementary.io
GNU General Public License v3.0
12 stars 3 forks source link

non-apps with metainfo component type of desktop application #95

Open danirabbit opened 1 year ago

danirabbit commented 1 year ago

What Happened?

There are some compulsory components that currently have a metainfo component type of "desktop-application" even though they're not exactly apps:

Steps to Reproduce

Change the component exclusion if statement for compulsories to include kind != DESKTOP_APPLICATION

Expected Behavior

These components should probably not declare themselves as "desktop-application" but its unclear to me what fits better.

Should they all be generic components with no "type" field?

Should "Authentication Agent", "Captive Network Assistant", and "Notifications" be considered a "service"?

OS Version

7.x (Horus)

Software Version

Latest release (I have run all updates)

Log Output

No response

Hardware Info

No response

kerunaru commented 8 months ago

What are the consequences of having those apps "declared" as desktop applications? 🤔

danirabbit commented 8 months ago

Sorry that wasn't clear in the original report, the issue is that we want to avoid duplicates and avoid listing apps under the "desktop components" category. However if we exclude application type components that currently also will exclude some things that are miscategorized as apps