Provide a Flatpak manifest

elementary / files

File browser designed for elementary OS

https://elementary.io

GNU General Public License v3.0

331 stars 78 forks source link

Provide a Flatpak manifest #1508

Closed danirabbit closed 3 years ago

danirabbit commented 4 years ago

See https://github.com/elementary/calculator/blob/master/io.elementary.calculator.yml as an example

jeremypw commented 4 years ago

I guess this will need a pretty porous sandbox :stuck_out_tongue:

Nautilus uses

    "finish-args": [
        "--share=ipc", "--socket=x11",
        "--socket=wayland",
        "--talk-name=org.gnome.OnlineAccounts",
        "--talk-name=org.freedesktop.Tracker1",
        "--filesystem=host",
        "--talk-name=org.gtk.vfs", "--talk-name=org.gtk.vfs.*",
        "--talk-name=ca.desrt.dconf", "--env=DCONF_USER_CONFIG_DIR=.config/dconf"
    ],

But Dolphin has more restrictive access to the filesystem for some reason

    "finish-args": [ "--device=dri",
                     "--share=ipc",
                     "--share=network",
                     "--socket=x11",
                     "--socket=wayland",
                     "--filesystem=home",
                     "--filesystem=/run/media",
                     "--talk-name=org.kde.kiod5",
                     "--talk-name=org.kde.JobViewServer",
                     "--talk-name=org.kde.kpasswdserver",
                     "--system-talk-name=org.freedesktop.UDisks2" ],

Marukesu commented 4 years ago

I tend to prefer the dolphin implementation over nautilus here

davidmhewitt commented 4 years ago

I tend to prefer the dolphin implementation over nautilus here

Yeah, well we don't really get a choice 😛

Dolphin's seems more restrictive because it uses the KIO bus. KIO is a daemon which essentially provides a file manager backend and Dolphin is just the user interface to that.

In theory, you can do that to some extent with gvfs, but I don't find it particularly weird that a file manager would ask for permissions to access the entire filesystem.

Marukesu commented 3 years ago

So the actual status of a files flatpak:

Can't delete folders, but deleting files works.
Can't open external apps
Can't show thumbnails

To build the manifest I need to make some changes on meson and services files:

added a portal and with-plank options so we can skip building the filechooser and plank.
renamed io.elementary.files.services to io.elementary.files.db.services because flatpak-builder fails because of the mismatching ids.
renamed io.elementary.files.Filemanager1.service to org.freedesktop.Filemanager1.service because flatpak install fails because of the wrong service name.

danirabbit commented 3 years ago

I'm going to go ahead and close this since we need a native build to provide the file chooser portal and this just doesn't seem like a good candidate for Flatpak

12people commented 2 years ago

Sounds like this issue was closed because Files does not make much sense as a Flatpak for elementary OS.

It might, however, be worth considering another use-case: using elementary Files on other distros, such as Fedora Silverblue. While Nautilus isn't bad by any means, elementary Files include Miller columns, which can be a huge productivity booster.

jeremypw commented 2 years ago

Probably needs someone to maintain a suitable fork on Flathub (and maybe a way of ensuring native installation on Elementary?)