search

elementary / files

File browser designed for elementary OS
https://elementary.io
GNU General Public License v3.0
322 stars 75 forks source link

Don't cancel file transfer on file manager window closing #1559

Open spotlesscoder opened 3 years ago

spotlesscoder commented 3 years ago

Just recognized that the file transfer stops when I close the main filemanager window?

WTF?

jeremypw commented 3 years ago

If confirmed this is a regression - ongoing file operations are supposed to inhibit closing the app.

jeremypw commented 3 years ago

@CodingSpiderFox Please confirm which version of elementary/Files you are running.

jeremypw commented 3 years ago

Just tried this on elementary 6.0. The file operation (copying a large file) continued even when the main window was closed (using the delete button). The progress window remained open and active.

spotlesscoder commented 3 years ago

It could be that this is already fixed as I use my own fork of files (which I can't patch since development has switched to focus on eOS 6.0)

Anyways, I'm using Hera 5.1.7

hanaral commented 3 years ago

(which I can't patch since development has switched to focus on eOS 6.0) Anyways, I'm using Hera 5.1.7

You should be able to download the last releases source archive and compile it from there. Could you test if it happens with that version of Files?

spotlesscoder commented 3 years ago

Last time i tried (which is a couple of weeks ago) there was a dependency missing which is not available on eOS 5.1.7 (I think it was libhandy if I remember correctly)

hanaral commented 3 years ago

Are you sure you didn't download the repo as an archive? The latest release tarball is from August last year and didn't yet have libhandy. The tagged releases are accessible from the right sidebar on the repo btw.

spotlesscoder commented 3 years ago

You mean this ZIP I should use?

https://github.com/elementary/files/archive/4.5.0.zip

hanaral commented 3 years ago

You mean this ZIP I should use? ...

@CodingSpiderFox

If it’s from august then yes

spotlesscoder commented 3 years ago

Yes, I think it was from August 23rd. I think I won't find the time to reproduce the issue in the near future, as I don't need to copy around my backups anymore at the moment